Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: simplify LibuvStreamWrap::DoWrite #24588

Closed
wants to merge 1 commit into from
Closed

src: simplify LibuvStreamWrap::DoWrite #24588

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1688/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 24, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/18913/

@addaleax addaleax added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 24, 2018
@addaleax
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18920/

@danbev
Copy link
Contributor

danbev commented Nov 29, 2018

Landed in 5e2ecd4.

@danbev danbev closed this Nov 29, 2018
danbev pushed a commit that referenced this pull request Nov 29, 2018
@addaleax @danbev
src: simplify LibuvStreamWrap::DoWrite
5e2ecd4 
PR-URL: #24588
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Nov 29, 2018
@addaleax @targos
src: simplify LibuvStreamWrap::DoWrite
a122ba5 
PR-URL: #24588
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
src: simplify LibuvStreamWrap::DoWrite
8f51032 
PR-URL: nodejs#24588
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs
Copy link
Member

This change does not land cleanly on v10.x-staging. I've added the backport-requested-v10.x label, but feel free to swap to dont-land-on- if this change shouldn't land on v10.x.

@addaleax addaleax deleted the simplify-dowrite branch February 12, 2019 20:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @danbev @BethGriggs @cjihrig @devsnek